[ofa-general] [PATCH 2/3] RDMA/cxgb3: fix page shift calculation in build_phys_page_list()

Roland Dreier rdreier at cisco.com
Wed Jan 30 09:01:14 PST 2008


 > This initial check is redundant, given:
 > 
 >         mask = buffer_list[0].addr ^ *iova_start;
 > 
 > and subsequent:
 > 
 >         if (mask & ~PAGE_MASK)
 >                 return ERR_PTR(-EINVAL);

Yes, good point.  Thanks!



More information about the general mailing list