[ofa-general] Re: [PATCH 0/16] ipoib offload patches

[Eli Cohen]

On Thu, 2008-01-31 at 15:15 +0200, Or Gerlitz wrote:
> Eli Cohen wrote:
> > following this email is a list of patches aimed at improving ipoib UD
> > mode performance by using various stateless offload facilities.
> > I am resending the full list again and would like to see it get into
> > 2.6.25. I denote them all as v4.
> 
> OK, Roland, except for the LSO patches I am done with my review so for 
> the below patches I say
> > 0001-IB-ipoib-Add-high-dma-support.patch
> > 0002-IB-ipoib-Add-s-g-support.patch
> > 0003-IB-core-Add-checksum-offload-support.patch
> > 0004-IB-ipoib-Add-checksum-offload-support.patch
> > 0005-IB-mlx4-Add-checksum-offload-support.patch
> > 0006-IB-mthca-Add-checksum-offload-support.patch
> > 0012-IB-ipoib-Add-ethtool-support-to-IPOIB.patch
> > 0013-IB-core-Add-support-for-modify-CQ.patch
> > 0014-IB-ipoib-Support-modifying-IPOIB-CQ-moderation-para.patch
> > 0015-IB-mlx4-Add-support-for-modifying-CQ-parameters.patch
> > 0016-IB-ipoib-Set-default-CQ-moderation-parameters.patch
> 
> Reviewed-by: Or Gerlitz <ogerlitz at voltaire.com>
> 
> I might be able to look on the below patches later next week, however 
> since the merge window has few more days, best if we can make progress 
> here with or without them.
> 
> > 0007-IB-core-Add-creation-flags-to-QPs.patch
> > 0008-IB-core-Add-support-for-LSO.patch
> > 0009-IB-ipoib-Add-LSO-support.patch
> > 0010-IB-mlx4-Add-creation-flags-to-mlx4-QPs.patch
> > 0011-IB-mlx4-Add-LSO-support-to-mlx4.patch
> 
> and, Eli, keep with the good work!
> 

Or, thanks for investing the time and effort in reviewing.

I would appreciate if more people could review and provide comments on
the patches above. Specifically on the patches the Or did not review as
I think they're important since they give performance boost for TCP.

Thanks.