[ofa-general] [PATCH] RDMA/nes: Remove write-only fields of struct nes_vnic

Roland Dreier rdreier at cisco.com
Tue Jul 1 21:07:08 PDT 2008


struct nes_vnic.get_cqp_request and .post_cqp_request are assigned but
never used.  Remove them.

Signed-off-by: Roland Dreier <rolandd at cisco.com>
---
And another one... let me know if there is some plan to use these fields
in the future and I'll drop this.

 drivers/infiniband/hw/nes/nes_hw.c |    2 --
 drivers/infiniband/hw/nes/nes_hw.h |    2 --
 2 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/infiniband/hw/nes/nes_hw.c b/drivers/infiniband/hw/nes/nes_hw.c
index 80e4866..0cea58b 100644
--- a/drivers/infiniband/hw/nes/nes_hw.c
+++ b/drivers/infiniband/hw/nes/nes_hw.c
@@ -1591,8 +1591,6 @@ int nes_init_nic_qp(struct nes_device *nesdev, struct net_device *netdev)
 				cpu_to_le32((u32)((u64)nesvnic->nic.frag_paddr[counter] >> 32));
 	}
 
-	nesvnic->get_cqp_request = nes_get_cqp_request;
-	nesvnic->post_cqp_request = nes_post_cqp_request;
 	nesvnic->mcrq_mcast_filter = NULL;
 
 	spin_lock_init(&nesvnic->nic.sq_lock);
diff --git a/drivers/infiniband/hw/nes/nes_hw.h b/drivers/infiniband/hw/nes/nes_hw.h
index 745bf94..4314ca2 100644
--- a/drivers/infiniband/hw/nes/nes_hw.h
+++ b/drivers/infiniband/hw/nes/nes_hw.h
@@ -1171,8 +1171,6 @@ struct nes_vnic {
 	struct nes_hw_nic_cq nic_cq;
 	u32    mcrq_qp_id;
 	struct nes_ucontext *mcrq_ucontext;
-	struct nes_cqp_request* (*get_cqp_request)(struct nes_device *nesdev);
-	void (*post_cqp_request)(struct nes_device*, struct nes_cqp_request *, int);
 	int (*mcrq_mcast_filter)( struct nes_vnic* nesvnic, __u8* dmi_addr );
 	struct net_device_stats netstats;
 	/* used to put the netdev on the adapters logical port list */
-- 
1.5.6




More information about the general mailing list