[ofa-general] Re: [PATCH v4 for-2.6.27] IPOIB: add LRO support.

[Or Gerlitz]

Roland Dreier wrote:
> Yes, in general I prefer not to have module parameters, especially those
> that duplicate functionality available through other mechanisms.
> However, having lro and max_aggr parameters seems to match existing
> practice for ethernet drivers, and 64 seems to be the common default for max_aggr.
OK, I understand that to some extent its fine to do what others (BTW its 
only 4 drivers under drivers/net that use LRO, so the sample size is 
kind of small) do. I still don't see why 64 makes sense, for example 
ipoib supports LSO on the xmit side, which means the network stack would 
submit SKBs whose data size is up to 64K, assuming the common mtu is 
2K-epsilon I would use a value of 64K/2K = ~32 for the max_aggr value, 
why use 64 ?!

Or.