[ofa-general] Re: [PATCH 3/3 v4] ib/ipoib: blocking multicast loopback ipoib packets

Or Gerlitz or.gerlitz at gmail.com
Thu Jul 3 15:04:50 PDT 2008


On 7/4/08, Roland Dreier <rdreier at cisco.com> wrote:

> Sorry, I don't have a magic solution for you.  To minimize pain about
>  ABI I think the only thing to do is minimize ABI changes.

fair-enough, so lets just try to take ABI changes to minimum...

> If a QP creation flag works for XRC then I would prefer not to add more
>  QP types I guess.  One of the ways that the QP creation flags were
>  originally sold to me was that XRC needed them anyway.  So I'm a bit
>  confused about where things have ended up.

I can't take this, we think that creation flags can be a good way to
go wrt minimizing ABI changes, I am not enough into the XRC impl to
tell why creation flags are not used there.


> I don't want to add both an XRC-specific mechanism and a more general
>  mechanism that XRC could have used but doesn't.  So yes the "framework
>  Z" approach that works for both seems like the best way forward.

OK, so do we agree that ABI wise one thing to handle is the new verb/s
plus their associated data structures (in our case just create_flags
field added to qp_init_attr) and second thing is placing the new verbs
into the verbs context structure?

Lets see what Jack says, we are fine with anything (yes) he would suggest.

Or.



More information about the general mailing list