[ofa-general] Issues with osm_sm_state_mgr_check_legality()

[Sasha Khapyorsky]

Hi Vincent,

On 10:41 Thu 03 Jul     , Vincent Ficet wrote:
> Hello,
>
> In opensm/opensm/osm_sm_state_mgr.c:osm_sm_state_mgr_check_legality(), I 
> noticed that the only valid signals that the SM can get while in the 
> IB_SMINFO_STATE MASTER are:
> - OSM_SM_SIGNAL_HANDOVER
> - OSM_SM_SIGNAL_HANDOVER_SENT
>
> However, in opensm/opensm/osm_sm_state_mgr.c:osm_sm_state_mgr_process(), we 
> see that the following signals can be received in the master state:
> - OSM_SM_SIGNAL_POLLING_TIMEOUT
> - OSM_SM_SIGNAL_HANDOVER
> - OSM_SM_SIGNAL_HANDOVER_SENT
> - OSM_SM_SIGNAL_WAIT_FOR_HANDOVER
> - OSM_SM_SIGNAL_DISCOVER
>
> Is this a bug, or am I missing anything here ?

I don't see an immediate bug here. osm_sm_state_mgr_check_legality() is
used only during SMInfo request processing so it covers only this flow
path and osm_sm_state_mgr_process() is called in different places.

Sasha