[ofa-general] [PATCH RFC] rds: add iwarp support

Olaf Kirch olaf.kirch at oracle.com
Mon Jul 14 01:01:29 PDT 2008


On Friday 11 July 2008 18:39:39 Jon Mason wrote:
> Changing to the SQD state in iWARP will cause the connection to be torn
> down.  Simply ignore this modify_qp calls, and iWARP is happy.

I guess actually both branches of the if statement could be
skipped for iWARP - there's no point in tweaking the RNR counter
for iWARP, even if it doesn't hurt on cxgb3, right?

Olaf

> 
> Thanks,
> Jon
> 
> Signed-off-by: Jon Mason <jon at opengridcomputing.com>
> 
> diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c
> index 5835a7e..12a6b0a 100644
> --- a/net/rds/ib_cm.c
> +++ b/net/rds/ib_cm.c
> @@ -101,7 +101,7 @@ static void rds_ib_connect_complete(struct rds_connection *conn, struct rdma_cm_
>  	 * so that we learn quickly when our credit accounting is
>  	 * buggy.
>  	 */
> -	if (ic->i_flowctl) {
> +	if (ic->i_flowctl && !ic->i_iwarp) {
>  		/* It seems we have to take a brief detour through SQD state
>  		 * in order to change the RNR retry count. */
>  		qp_attr.qp_state = IB_QPS_SQD;
> 



-- 
Olaf Kirch  |  --- o --- Nous sommes du soleil we love when we play
okir at lst.de |    / | \   sol.dhoop.naytheet.ah kin.ir.samse.qurax



More information about the general mailing list