[ofa-general] Re: [ewg] [PATCH] IB/core: remove an always true condition

Roland Dreier rdreier at cisco.com
Tue Jul 15 10:56:20 PDT 2008


 > -	if (hdr.command < 0				||
 > -	    hdr.command >= ARRAY_SIZE(uverbs_cmd_table) ||
 > +	if (hdr.command >= ARRAY_SIZE(uverbs_cmd_table) ||

I prefer to leave the code in as being more self-documenting and
resilient against future changes.  The compiler should be able to
optimize away the always-true part anyway.



More information about the general mailing list