[ofa-general] ***SPAM*** [PATCH 1/3 v2] libibverbs : add new verbs: create_qp_expanded

[Ron Livne]

should be:
       __u8 reserved;
       __u32 create_flags;
       __u32 reserved1;

Why do we need a 32 bit create_flags if the uverbs layer has only 8 bits?

Ron


On Tue, Jul 22, 2008 at 10:09 AM, Jack Morgenstein
<jackm at dev.mellanox.co.il> wrote:
> On Monday 21 July 2008 23:25, ronli at voltaire.com wrote:
>> +struct ibv_create_qp_expanded {
>> +     __u32 command;
>> +     __u16 in_words;
>> +     __u16 out_words;
>> +     __u64 response;
>> +     __u64 user_handle;
>> +     __u32 pd_handle;
>> +     __u32 send_cq_handle;
>> +     __u32 recv_cq_handle;
>> +     __u32 srq_handle;
>> +     __u32 max_send_wr;
>> +     __u32 max_recv_wr;
>> +     __u32 max_send_sge;
>> +     __u32 max_recv_sge;
>> +     __u32 max_inline_data;
>> +     __u8  sq_sig_all;
>> +     __u8  qp_type;
>> +     __u8  is_srq;
>
>
>> +     __u8  create_flags;
> should be:
>        __u8 reserved;
>        __u32 create_flags;
>        __u32 reserved1;
>
> The reserved1 field is needed for the proper alignment of the u64 driver_data field
> in all situations.
>
>> +     __u64 driver_data[0];
>> +};
>> +
>
> - Jack
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>