[ofa-general] [PATCH V2] Add ib_trap_str function to ib_types.h and use it in INFO prints of OpenSM

[Ira Weiny]

I just followed the convention used but yea I think you are right.

Ira


On Thu, 24 Jul 2008 06:25:17 +0300
Sasha Khapyorsky <sashak at voltaire.com> wrote:

> Hi Ira,
> 
> On 08:03 Wed 23 Jul     , Ira Weiny wrote:
> > 
> > Signed-off-by: Ira K. Weiny <weiny2 at llnl.gov>
> > ---
> >  opensm/include/iba/ib_types.h |   43 +++++++++++++++++++++++++++++++++++++++++
> >  opensm/opensm/osm_inform.c    |    3 +-
> >  opensm/opensm/osm_trap_rcv.c  |   10 +++++++-
> >  3 files changed, 53 insertions(+), 3 deletions(-)
> 
> This adds almost 2k text to opensm executable:
> 
> sashak at sashak ~/src/m/opensm $ size opensm/.libs/old-opensm 
> text    data     bss     dec     hex filename
> 561868    1536   19668  583072   8e5a0 opensm/.libs/opensm
> sashak at sashak ~/src/m/opensm $ size opensm/.libs/opensm 
> text    data     bss     dec     hex filename
> 563740    1536   19668  584944   8ecf0 opensm/.libs/opensm
> 
> Wouldn't it be better to put ib_trap_str() to osm_helper.c and not make
> it inline?
> 
> Sasha