[ofa-general] Re: [PATCH 1/3] mcast loopback block

Roland Dreier rdreier at cisco.com
Mon Jun 2 09:35:21 PDT 2008


 > +	IB_DEVICE_BLOCK_LOOPBACK        = (1<<22),

This clashes with MEM_MGT_EXTENSIONS.

Do we really need to burn a capability bit for this?  Would it cause any
problems to make IB_QP_BLOCK_LOOPBACK a hint that the underlying HCA may
or may not support?

 >  enum ib_qp_create_flags {
 >  	IB_QP_CREATE_IPOIB_UD_LSO	= 1 << 0,
 > +	IB_QP_BLOCK_LOOPBACK            = 1 << 1,
 > };

The naming convention is that this should be IB_QP_CREATE_BLOCK_LOOPBACK.

 - R.



More information about the general mailing list