[ofa-general] Re: [PATCH v3 08/13] QLogic VNIC: sysfs interface implementation for the driver

[Greg KH]

On Tue, Jun 03, 2008 at 11:55:00PM +0530, Amar Mudrankit wrote:
> Documentation/filesystems/configfs/configfs.txt <<snip>>
> 
>                   [Using configfs]
> 
>                   Like sysfs, attributes should be ASCII text files, preferably
>                   with only one value per file.  The same efficiency caveats from sysfs
>                   apply.  Don't mix more than one attribute in one attribute file.
> 
> It looks like configfs also does not allow multiple attributes per file.

But you have attribute/value pairs, right?  Just create multiple
attribute files then in configfs for them.

> So, in that case, shall we modify our sysfs code to support one value per
> sysfs file? With this approach, the impact on user space applications that
> we have which depend on the qlgc_vnic driver sysfs interface will be less.

If you want to, but as this looks like it is used for configuration, I
suggest using configfs instead.

thanks,

greg k-h