[ofa-general] Re: [PATCH] infiniband-diags/src/ibnetdiscover.c: Fix the PortInfo data on the port we discover a switch on.

Sasha Khapyorsky sashak at voltaire.com
Sat Jun 7 21:29:10 PDT 2008


On 19:12 Thu 05 Jun     , Ira Weiny wrote:
> I noticed over the last couple days that ibnetdiscover would print the
> incorrect speed on the port I would run ibnetdiscover from.  For example:
> 
> Switch  24 "S-0008f10400411f56"         # "SW1 wopr ISR9024D (MLX4 FW)" base port 0 lid 11 lmc 0
> ...
> [13]    "H-0002c90200219e64"[1](2c90200219e65)          # "wopri" lid 32 4xSDR
> 
>                                                                            ^^^
>                (Note from the switch side of things it thinks the speed is SDR.)
> ...
> Ca      2 "H-0002c90200219e64"          # "wopri"
> [1](2c90200219e65)      "S-0008f10400411f56"[13]                # lid 32 lmc 0 "SW1 wopr ISR9024D (MLX4 FW)" lid 11 4xDDR
> 
>                                                                                                                      ^^^
>                                                                                                            (but here DDR.)
> 
> It turns out that when you first discover a switch the port object created gets
> the PortInfo of Port "0".
> 
> This patch queries again for the PortInfo of the port we "came in on".
> 
> Ira
> 
> 
> From 5bc66af276c7baabd4d66be9df0379271cb625b4 Mon Sep 17 00:00:00 2001
> From: Ira K. Weiny <weiny2 at llnl.gov>
> Date: Thu, 5 Jun 2008 19:03:44 -0700
> Subject: [PATCH] infiniband-diags/src/ibnetdiscover.c: Fix the PortInfo data on the port we discover a switch on.
> 
>    Previously the portinfo data for that port object would be the PortInfo of
>    port "0" of the switch.  Specifically this would cause the speed of the link
>    to be printed incorrectly.
> 
> Signed-off-by: Ira K. Weiny <weiny2 at llnl.gov>

Applied. Thanks.

Sasha



More information about the general mailing list