[ofa-general] Re: [PATCH 1/3] mcast loopback block

[Ron Livne]

On Mon, Jun 2, 2008 at 7:35 PM, Roland Dreier <rdreier at cisco.com> wrote:

>  > +    IB_DEVICE_BLOCK_LOOPBACK        = (1<<22),
>
> This clashes with MEM_MGT_EXTENSIONS.


looking in the for-2.6.27 branch of your tree,
IB_DEVICE_SEND_W_INV (21) was removed and IB_DEVICE_MEM_MGT_EXTENSIONS (21)
was added instead.
So it seems that the value of 22 is free for adding a cap bit, if we decide
we go this way.


>
> Do we really need to burn a capability bit for this?  Would it cause any
> problems to make IB_QP_BLOCK_LOOPBACK a hint that the underlying HCA may
> or may not support?
>
>  >  enum ib_qp_create_flags {
>  >      IB_QP_CREATE_IPOIB_UD_LSO       = 1 << 0,
>  > +    IB_QP_BLOCK_LOOPBACK            = 1 << 1,
>  > };
>
> The naming convention is that this should be IB_QP_CREATE_BLOCK_LOOPBACK.


You are right, will be fixed.


>
>  - R.
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit
> http://openib.org/mailman/listinfo/openib-general
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20080612/538fac89/attachment.html>