[ofa-general] [PATCH] opensm/osm_ucast_ftree.c : TRIVIAL fixes in log handling

Yevgeny Kliteynik kliteyn at dev.mellanox.co.il
Tue Jun 17 04:05:42 PDT 2008


Hi Sasha,

OSM_LOG_ENTER() at the beginning of the function and
OSM_LOG_EXIT() at the end of the function were missing.

Signed-off-by:  Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>
---
 opensm/opensm/osm_ucast_ftree.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/opensm/opensm/osm_ucast_ftree.c b/opensm/opensm/osm_ucast_ftree.c
index dc61130..3ee2bdc 100644
--- a/opensm/opensm/osm_ucast_ftree.c
+++ b/opensm/opensm/osm_ucast_ftree.c
@@ -1260,6 +1260,8 @@ static void __osm_ftree_fabric_dump_hca_ordering(IN ftree_fabric_t * p_ftree)
 	FILE *p_hca_ordering_file;
 	char *filename = "opensm-ftree-ca-order.dump";

+	OSM_LOG_ENTER(&p_ftree->p_osm->log);
+
 	snprintf(path, sizeof(path), "%s/%s",
 		 p_ftree->p_osm->subn.opt.dump_files_dir, filename);
 	p_hca_ordering_file = fopen(path, "w");
@@ -1267,8 +1269,7 @@ static void __osm_ftree_fabric_dump_hca_ordering(IN ftree_fabric_t * p_ftree)
 		OSM_LOG(&p_ftree->p_osm->log, OSM_LOG_ERROR, "ERR AB01: "
 			"cannot open file \'%s\': %s\n", filename,
 			strerror(errno));
-		OSM_LOG_EXIT(&p_ftree->p_osm->log);
-		return;
+		goto Exit;
 	}

 	/* for each leaf switch (in indexing order) */
@@ -1309,6 +1310,10 @@ static void __osm_ftree_fabric_dump_hca_ordering(IN ftree_fabric_t * p_ftree)
 	/* done going through all the leaf switches */

 	fclose(p_hca_ordering_file);
+
+Exit:
+	OSM_LOG_EXIT(&p_ftree->p_osm->log);
+	return;
 }				/* __osm_ftree_fabric_dump_hca_ordering() */

 /***************************************************/
-- 
1.5.1.4




More information about the general mailing list