[ofa-general] [PATCH RFCv2 2/2] RDMA/cxgb3: Add support for protocol statistics.

Roland Dreier rdreier at cisco.com
Wed Jun 18 13:15:43 PDT 2008


 > +	stats->iw.ipInReceive = m.ipInReceive_hi + m.ipInReceive_lo;

Surely all the code like this is wrong?  Shouldn't it be more like

	stats->iw.ipInReceive = ((u64) m.ipInReceive_hi << 32) +
		m.ipInReceive_lo;

 - R.



More information about the general mailing list