[ofa-general] Re: [PATCH 1/4] rdma/addr: keep the netdevice name in struct rdma_dev_addr

[Or Gerlitz]

On 6/18/08, Roland Dreier <rdreier at cisco.com> wrote:
>> just saving pointer to the netdevice seemed quite not elegant...

> To me using the pointer to the netdev seems much cleaner than doing a
>  string comparison on the name, but I'm probably missing something.  Why
>  didn't you like that idea?

I was thinking that I would need to go into reference counting / book
keeping on the netdevice, but as Steve noted, it seems doable, and I guess I
don't need to issue a dev_get() just for keeping the copy of neigh->dev,
correct? since its holds the rtnl lock, the netevent notififier should
provide a safe context for comparision event->dev to id->addr->dev.  If we
agree on this approach and you prefer it, I can change the patch.

Or.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20080618/29e61b34/attachment.html>