[ofa-general] [PATCH 1/4] sdp: Use sdp_set_state()

Sean Hefty sean.hefty at intel.com
Thu Jun 19 10:04:22 PDT 2008


>+static inline void sdp_set_state(struct sock *sk, int state)
>+{
>+	sk->sk_state = state;
>+}

Why have this abstraction?

>-	sk->sk_state = TCP_CLOSE;
>+	sdp_set_state(sk, TCP_CLOSE);

IMO, the previous code is simpler to maintain.

- Sean




More information about the general mailing list