[ofa-general] Re: [PATCH] IB/mlx4: Check completion done when a command

Roland Dreier rdreier at cisco.com
Thu Jun 19 14:44:23 PDT 2008


 > Because if we're going to merge something upstream, we might as well
 > merge the real fix (that fixes both mthca and mlx4) rather than merging
 > a workaround and then leaving the bug for another year or however long
 > it takes to hit it again.

Oh and of course the fact that the patch requires driver code to look at
internal implementation details of struct completion is a big hint that
this is the wrong approach too.

 - R.



More information about the general mailing list