[ofa-general] Re: [PATCH v3] opensm/osm_qos_policy.c: log matched QoS criteria

[Sasha Khapyorsky]

On 14:46 Sat 21 Jun     , Yevgeny Kliteynik wrote:
>
> Many QoS matching rules are overlapping, and the user not always
> gets what he wants. This log message helps debug policy file,
> and shows why a certain ulp/application got a certain sl.

Ok, then should something like a patch below be sufficient for this?

Sasha

diff --git a/opensm/opensm/osm_qos_policy.c b/opensm/opensm/osm_qos_policy.c
index f1d4e54..7999122 100644
--- a/opensm/opensm/osm_qos_policy.c
+++ b/opensm/opensm/osm_qos_policy.c
@@ -701,6 +701,11 @@ static osm_qos_match_rule_t *__qos_policy_get_match_rule_by_params(
 	if (list_iterator == cl_list_end(&p_qos_policy->qos_match_rules))
 		return NULL;
 
+	OSM_LOG(&p_qos_policy->p_subn->p_osm->log, OSM_LOG_DEBUG,
+		"request matched by \'%s\' rule, qos_level is \'%s\'\n",
+		p_qos_match_rule->use ? p_qos_match_rule->use : "no desc",
+		p_qos_match_rule->p_qos_level->name);
+
 	return p_qos_match_rule;
 }				/* __qos_policy_get_match_rule_by_pr() */