[ofa-general] Re: [PATCH v3] opensm/osm_qos_policy.c: log matched QoS criteria

Yevgeny Kliteynik kliteyn at dev.mellanox.co.il
Sat Jun 21 23:30:19 PDT 2008


Sasha Khapyorsky wrote:
> On 22:45 Sat 21 Jun     , Yevgeny Kliteynik wrote:
>> No, it won't be sufficient, because some matching rules do not
>> explain how do they match the path queries. For instance, "sdp"
>> doesn't say what service ID does it cover.
> 
> But selected matching rule (and qos level) will be shown - this should
> provide basic information about what is going on. No?

ULP section of the policy file doesn't have separate qos-matching-rule
and separate qos-level. Each line in this section internally generates
matching rule, and links it to one of the pre-generated simple qos levels
that has only SL.
Do I want to explain it to the user? No. That's the whole point of the ULP
section - the user is not aware of the full policy file syntax and semantics.

However, the user does know that OSM is enforcing qos according to path queries,
and the single message that I added shows *why* certain ulp/application got
certain SL. The patch that I've suggested help the user to understand *what*
matching rule was matched, but not *why*.

-- Yevgeny

> Sasha
> 




More information about the general mailing list