[ofa-general] Re: [PATCH 6/11] core: XRC - file descriptors associated with XRC domains

Roland Dreier rdreier at cisco.com
Mon Jun 23 14:08:41 PDT 2008


 > +static struct inode * xrc_fd2inode(unsigned int fd)
 > +{
 > +	struct file * f = fget(fd);
 > +
 > +	if (!f)
 > +		return NULL;
 > +
 > +	return f->f_dentry->d_inode;
 > +}

Am I missing something, or is there no fput() that matches this fget()?

Is there some reason why we don't need an igrab() of the inode we're
using here?  (If we do need it then a corresponding iput() when we're
done with the inode is required of course)

 - R.



More information about the general mailing list