[ofa-general] Re: [PATCH 8/11] core: XRC receive-only QPs

Roland Dreier rdreier at cisco.com
Mon Jun 23 14:53:22 PDT 2008


 > @@ -769,6 +775,7 @@ struct ib_ucontext {
 >  	struct list_head	srq_list;
 >  	struct list_head	ah_list;
 >  	struct list_head	xrc_domain_list;
 > +	struct list_head	xrc_reg_qp_list;
 >  	int			closing;
 >  };

Wouldn't it be cleaner to keep the like of recv QPs per xrcd?  Then you
wouldn't have to do stuff like:

 > +	list_for_each_entry(tmp, &file->ucontext->xrc_reg_qp_list, list)
 > +		if (cmd.xrcd_handle == tmp->domain_handle) {

instead you could just do a list_empty() test.

 - R.



More information about the general mailing list