[ofa-general] Re: [PATCH v2 for-2.6.27] IPOIB: add LRO support.

[Vladimir Sokolovsky]

On Tue, Jun 24, 2008 at 11:56 PM, Roland Dreier <rdreier at cisco.com> wrote:

> To be honest this looks like a step backwards...
>
>  > +static ssize_t show_use_lro(struct device *d, struct device_attribute
> *attr,
>  > +                     char *buf)
>  > +{
>  > +    struct ipoib_dev_priv *priv = netdev_priv(to_net_dev(d));
>  > +
>  > +    if (priv->lro.use_lro)
>  > +            return sprintf(buf, "yes\n");
>  > +    else
>  > +            return sprintf(buf, "no\n");
>  > +}
>
> This looks like a crazy interface ("yes"/"no" vs 1/0??) and in any case
> I think using the existing ethtool support to control LRO would be much
> simpler and better for users.
>
>  - R.
>
>
I can change "yes" to "1" and "no" to "0".
I don't see that there is LRO support in the userspace ethtool.


Regards,
VLadimir
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20080625/1f7c152b/attachment.html>