[ofa-general] Re: [PATCH v2] net/inet_lro: remove setting skb->ip_summed when not LRO-able

David Miller davem at davemloft.net
Fri Jun 27 20:09:14 PDT 2008


From: Eli Cohen <eli at dev.mellanox.co.il>
Date: Wed, 25 Jun 2008 18:29:12 +0300

> When an SKB cannot be chained to a session, the current code attempts
> to "restore" its ip_summed field from lro_mgr->ip_summed. However,
> lro_mgr->ip_summed does not hold the original value; in fact, we'd
> better not touch skb->ip_summed since it is not modified by the code
> in the path leading to a failure to chain it.
> Also use a cleaer comment to the describe the ip_summed field of
> struct net_lro_mgr.
> 
> Issue raised by Or Gerlitz <ogerlitz at voltaire.com>
> 
> Signed-off-by: Eli Cohen <eli at mellanox.co.il>

Patch applied, thanks everyone.



More information about the general mailing list