[ofa-general] [PATCH v3 for-2.6.27] IPOIB: add LRO support.

[Eli Cohen]

On Sun, Jun 29, 2008 at 09:04:18AM +0300, Or Gerlitz wrote:
>> +	if (unlikely(skb->ip_summed != CHECKSUM_UNNECESSARY))
>> +		return -1;
> As I wrote you in a comment for the v1 post which was ignored, please don't 
> associate LRO and checksum offload, as LRO is software only feature. Either 
> this check be removed or this function be rewritten in a way that allow 
> also for devices which don't support checksum offload to use lro.

We agree that you can't link an SKB unless you know its checksum is
correct, right? So I suggest that we just add a comment here saying
something like this:

     /* in the future we may add an else cluase that verifies the
      * checksum and allows devices which do not calculate checksum
      * to use LRO */
+    if (unlikely(skb->ip_summed != CHECKSUM_UNNECESSARY))
+            return -1;

> once you have added the ethtool support to set/unset LRO per device, I 
> don't see the need for having this ipoib_use_lro module param, I suggest to 
> remove it.
>
We still want to have the default value being controlled by a module
parameter.