[ofa-general] Re: [PATCH v2] [TRIVIAL] opensm/osm_state_mgr.c: fixing some data types

Sasha Khapyorsky sashak at voltaire.com
Mon Jun 30 02:06:52 PDT 2008


On 11:52 Mon 30 Jun     , Yevgeny Kliteynik wrote:
>
> cl_ptr_vector_get_size() returns uint32_t,

Correct. I meant cl_ptr_vector_at() gets size_t as second parameter.

> and the value is lid,
> which means that the vector can't be longer than uint16_t.

It doesn't matter - we need to use valid types in our APIs.

>> I think the proper solution for this is to use
>> '%zu' format in OSM_LOG().
>
> OK, patch shortly.

Thanks.

Sasha



More information about the general mailing list