[ofa-general] ib_create_fmr_pool do INIT_HLIST_NODE only if cache is enabled

Roland Dreier rdreier at cisco.com
Sun Mar 9 13:51:30 PDT 2008


 > -                       INIT_HLIST_NODE(&fmr->cache_node);

 > +                       if (params->cache) {
 > +                               INIT_HLIST_NODE(&fmr->cache_node);
 > +                       }

I guess we could do that but in practice it doesn't make any
difference, does it?  Adding the if statement makes the code bigger
(and it's not a fast path anyway).

(BTW the kernel style is to leave out the { } around a single line block)

 - R.



More information about the general mailing list