[ofa-general] Re: [PATCH 2/10] IB/core: Add creation flags to QPs

[Eli Cohen]

On Fri, 2008-03-28 at 14:32 -0700, Roland Dreier wrote:
> Thanks, I applied this with some extra code in all the low-level
> drivers to make sure that the create_flags are passed in as 0.  Does
> that make sense to everyone?
> 
As far as I could see, all kernel consumers clear struct ib_qp_init_attr
before calling ib_create_qp() and for user space we clear this too. The
only hole is that rdma_create_qp() is exported and someone may be
calling this function without clearing struct ib_qp_init_attr. But I
think your approach is safer and should be used.