[ofa-general] Re: [PATCH] mlx4/profile.c: fix warning res_name defined but not used

[Alexander Beregalov]

2008/11/4 Roland Dreier <rdreier at cisco.com>:
> Thanks.  What if we fix this like the following instead -- change
> mlx4_dbg so it always looks to the compiler like it uses all its
> parameters?  This generates the same code for me, and looks cleaner in
> that it actually reduces the amount of #ifdef'ed stuff.
Yes, it looks better.
> ---
>  drivers/net/mlx4/mlx4.h |    9 +++------
>  1 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/mlx4/mlx4.h b/drivers/net/mlx4/mlx4.h
> index fa431fa..56a2e21 100644
> --- a/drivers/net/mlx4/mlx4.h
> +++ b/drivers/net/mlx4/mlx4.h
> @@ -87,6 +87,9 @@ enum {
>
>  #ifdef CONFIG_MLX4_DEBUG
>  extern int mlx4_debug_level;
> +#else /* CONFIG_MLX4_DEBUG */
> +#define mlx4_debug_level       (0)
> +#endif /* CONFIG_MLX4_DEBUG */
>
>  #define mlx4_dbg(mdev, format, arg...)                                 \
>        do {                                                            \
> @@ -94,12 +97,6 @@ extern int mlx4_debug_level;
>                        dev_printk(KERN_DEBUG, &mdev->pdev->dev, format, ## arg); \
>        } while (0)
>
> -#else /* CONFIG_MLX4_DEBUG */
> -
> -#define mlx4_dbg(mdev, format, arg...) do { (void) mdev; } while (0)
> -
> -#endif /* CONFIG_MLX4_DEBUG */
> -
>  #define mlx4_err(mdev, format, arg...) \
>        dev_err(&mdev->pdev->dev, format, ## arg)
>  #define mlx4_info(mdev, format, arg...) \
>