[ofa-general] [RMDA CM IPv6 support. PATCHv4 1/6] AF_INET6 support for rdma_bind_addr

Sean Hefty sean.hefty at intel.com
Sun Nov 30 23:41:37 PST 2008


>Yes, it's a tricky balance.  You don't want to combine multiple ideas in
>one patch, because such patches are hard to review and hard to debug
>later.  But splitting one ideas into multiple patches also causes
>similar problems (and you have to get the pieces in the right order
>too).  And of course the whole question of what constitues an "idea" is
>rather subjective.  So we just do the best we can.

The patch set taken collectively looks good to me.  I think it makes sense to
view the series as 2 patches, one for ib_addr (patches 4-6), and one for rdma_cm
(patches 1-3).  The ib_addr patch should come first.

- Sean




More information about the general mailing list