[ofa-general] RE: [PATCH 13/13] RDMA/nes: Enhanced PFT management scheme

Roland Dreier rdreier at cisco.com
Fri Oct 3 13:16:05 PDT 2008


 > spin_unlock_irqrestore should be outside of the if(...).
 > 
 > 
 > 
 > +  if (!mc_all_on) {
 > +  ...
 > +			nes_write_indexed(nesdev,
 > NES_IDX_NIC_UNICAST_ALL,
 > +
 > nic_active);
 > +		}
 >  	}
 > +	spin_unlock_irqrestore(&nesadapter->resource_lock, flags);
 > }
 > 
 > 
 > If you can fix it again that would be great but let me know if you want
 > a v2 patch.

That's what I did in the patch I rolled in.  It's working here so I
think I got it right.



More information about the general mailing list