[ofa-general] Re: [PATCH 0/6] opensm: Unicast Routing Cache

Yevgeny Kliteynik kliteyn at dev.mellanox.co.il
Thu Oct 9 18:29:50 PDT 2008


Hi Sasha,

Sasha Khapyorsky wrote:
> Hi Evgeny,
> 
> On 03:26 Mon 06 Oct     , Yevgeny Kliteynik wrote:
>> The patches are:
>>  - patch 1/6: move lft_buf from ucast_mgr to osm_switch
>>  - patch 2/6: Add "-A" or "--ucast_cache" option to opensm
>>  - patch 3/6: adding osm_ucast_cache.{c,h} files (this is
>>    the cache implementation itself)
>>  - patch 4/6: adding new cache files to makefile
>>  - patch 5/6: integrating unicast cache into the discovery
>>    and ucast manager
>>  - patch 6/6: man entry for cached routing
> 
> Pathes 1,2,4,6 look fine for me. Will comment on others.

Thanks for the review and the patches. Didn't manage to address
all your comments yet - will do it tomorrow.
One question though: how to deal with the incremental patches that
you sent me? Should I apply them to my branch and then issue one
V2 patch instead of the old one, or will you apply the original
patch, followed by all the incremental (yours and mine)?

-- Yevgeny

> Sasha
> 




More information about the general mailing list