[ofa-general] [infiniband-diags] if perfquery -a is specified loop through ports if required and aggregate output

Sasha Khapyorsky sashak at voltaire.com
Sat Oct 11 13:03:22 PDT 2008


On 16:03 Fri 10 Oct     , Al Chu wrote:
> Oops, forgot to attach the patch.  Here it is.
> 
> Al
> 
> On Fri, 2008-10-10 at 16:02 -0700, Al Chu wrote:
> > Hey Sasha,
> > 
> > And finally the big patch.  If -a is specified and AllPortSelect is not
> > supported (and -l isn't specified) loop through all ports and aggregate
> > them into one output.
> > 
> > So the patch is a tad lengthy given the manual packet parsing/counting
> > that had to be done.  I'm not aware of any libs/helper funcs in OFED
> > that could have made this code shorter.  Please let me know if there are
> > some obvious funcs that could make this better. 
> > 
> > Also, my understanding is that in IB, counters don't wrap around.  When
> > they get to the max they stay at the max.  So wrap-around checks for all
> > of the counters is there as I added things up.  Couldn't find some
> > wrapper funcs for this in OFED already.  So hopefully I'm not repeating
> > code.
> > 
> > Al
> > 
> -- 
> Albert Chu
> chu11 at llnl.gov
> Computer Scientist
> High Performance Systems Division
> Lawrence Livermore National Laboratory

> >From 5864bf543181dda556e41bfb6b7c2780faeb3035 Mon Sep 17 00:00:00 2001
> From: Albert Chu <chu11 at llnl.gov>
> Date: Thu, 9 Oct 2008 16:39:19 -0700
> Subject: [PATCH] aggregate port counters for single output under --all_ports
> 
> 
> Signed-off-by: Albert Chu <chu11 at llnl.gov>

All applied. Thanks.

Sasha



More information about the general mailing list