[ofa-general] [PATCH 1/3] IB/ipath - fix the length returned in loopback UD completion queue entries

Ralph Campbell ralph.campbell at qlogic.com
Mon Oct 27 15:44:18 PDT 2008


On Mon, 2008-10-27 at 15:30 -0700, Roland Dreier wrote:
> > UD packets sent to the local IB port (loopback) have a zero length
>  > reported in the send work request completion entry. This fixes it
>  > by using a copy of the WQE to copy the data.
> 
> According to the IB spec (as I read it at least), the bytes transferred
> field of a completion entry is only defined for receive completions, and
> for RDMA read and atomic operation send completions.  The value in a UD
> send completion is undefined anyway.  So is this patch really worth it?

I guess not. I set the length in the non-loopback path and thought
it should be consistent. I don't know what applications might check
it but if the spec. says it isn't valid then I guess it makes more
sense to make things consistent by not setting the length in the
other cases.




More information about the general mailing list