[ofa-general] Re: [PATCH] opensm: notify master SM with trap 144 (not finished)

[Sasha Khapyorsky]

On 09:50 Wed 29 Oct     , Hal Rosenstock wrote:
> Sasha,
> 
> On Tue, Oct 28, 2008 at 4:27 PM, Hal Rosenstock
> <hal.rosenstock at gmail.com> wrote:
> > Sasha,
> >
> > On Sat, Oct 25, 2008 at 4:01 PM, Sasha Khapyorsky <sashak at voltaire.com> wrote:
> >>
> >> When entering standby state (after discovery) notify master SM about us.
> >> In case when SMA doesn't support trap sending (specifically trap 144 on
> >> PortInfo:CapabilityMask change - isSM bit, example is current ConnectX
> >> firmware - 2.5.0) this is only way to notify the current master SM that
> >> another SM is running.
> >
> > So is the trap sent unconditionally (since there's no way of knowing
> > whether the SMA supports this or not) ? Is the only downside the extra
> > Trap/TrapRepress when the SMA does support this ?
> >
> > Seems to me that the right fix is to the Connect-X SMA.
> >
> > Also, what happens once the Connect-X SMA is fixed ? Does this code persist ?
> 
> One approach might be to conditionalize this trap when Connect-X and
> ultimately on the firmware versions which don't support this. Another
> would be to add an option which defaults to off and needs to be set
> for Connect-X manually.

Does not CapabilityMask checking do the same (but w/out FW version
tricks)?

Sasha