[ofa-general] Re: [PATCH 1/5] drivers/infiniband/hw: Drop code after return

[Richard Genoud]

2008/9/11 Julia Lawall <julia at diku.dk>:
> From: Julia Lawall <julia at diku.dk>
>
> The break after the return serves no purpose.
>
> Signed-off-by: Julia Lawall <julia at diku.dk>
Reviewed-by: Richard Genoud <richard.genoud at gmail.com>
> ---
>  drivers/infiniband/hw/amso1100/c2_provider.c |    1 -
>  drivers/infiniband/hw/nes/nes_verbs.c        |    3 ---
>  2 files changed, 4 deletions(-)
>
> diff -u -p a/drivers/infiniband/hw/amso1100/c2_provider.c b/drivers/infiniband/hw/amso1100/c2_provider.c
> --- a/drivers/infiniband/hw/amso1100/c2_provider.c
> +++ b/drivers/infiniband/hw/amso1100/c2_provider.c
> @@ -272,7 +272,6 @@ static struct ib_qp *c2_create_qp(struct
>                pr_debug("%s: Invalid QP type: %d\n", __func__,
>                        init_attr->qp_type);
>                return ERR_PTR(-EINVAL);
> -               break;
>        }
>
>        if (err) {
> diff -u -p a/drivers/infiniband/hw/nes/nes_verbs.c b/drivers/infiniband/hw/nes/nes_verbs.c
> --- a/drivers/infiniband/hw/nes/nes_verbs.c
> +++ b/drivers/infiniband/hw/nes/nes_verbs.c
> @@ -1467,7 +1467,6 @@ static struct ib_qp *nes_create_qp(struc
>                default:
>                        nes_debug(NES_DBG_QP, "Invalid QP type: %d\n", init_attr->qp_type);
>                        return ERR_PTR(-EINVAL);
> -                       break;
>        }
>
>        /* update the QP table */
> @@ -2498,7 +2497,6 @@ static struct ib_mr *nes_reg_user_mr(str
>                        nes_debug(NES_DBG_MR, "Leaving, ibmr=%p", ibmr);
>
>                        return ibmr;
> -                       break;
>                case IWNES_MEMREG_TYPE_QP:
>                case IWNES_MEMREG_TYPE_CQ:
>                        nespbl = kzalloc(sizeof(*nespbl), GFP_KERNEL);
> @@ -2572,7 +2570,6 @@ static struct ib_mr *nes_reg_user_mr(str
>                        nesmr->ibmr.lkey = -1;
>                        nesmr->mode = req.reg_type;
>                        return &nesmr->ibmr;
> -                       break;
>        }
>
>        return ERR_PTR(-ENOSYS);
>