[ofa-general] Re: [PATCH] iw_cxgb3: populate active_mtu in ib_port_attr

[Steve Wise]

Acked-by: Steve Wise <swise at opengridcomputing.com>

Jon Mason wrote:
> When running ibv_devinfo, the active_mtu returned is garbage.  This is
> due to the field not being populated in the query_port function in the
> driver.  The patch below populates the active_mtu field with a MTU of
> 2k.  It also zeros the struct, so that any new additions to it will
> return 0.
>
> Thanks,
> Jon
>
> Signed-Off-By: Jon Mason <jon at opengridcomputing.com>
>
> diff --git a/drivers/infiniband/hw/cxgb3/iwch_provider.c b/drivers/infiniband/hw/cxgb3/iwch_provider.c
> index eb778bf..ecff980 100644
> --- a/drivers/infiniband/hw/cxgb3/iwch_provider.c
> +++ b/drivers/infiniband/hw/cxgb3/iwch_provider.c
> @@ -1155,13 +1155,11 @@ static int iwch_query_port(struct ib_device *ibdev,
>  			   u8 port, struct ib_port_attr *props)
>  {
>  	PDBG("%s ibdev %p\n", __func__, ibdev);
> +
> +	memset(props, 0, sizeof(struct ib_port_attr));
>  	props->max_mtu = IB_MTU_4096;
> -	props->lid = 0;
> -	props->lmc = 0;
> -	props->sm_lid = 0;
> -	props->sm_sl = 0;
> +	props->active_mtu = IB_MTU_2048;
>  	props->state = IB_PORT_ACTIVE;
> -	props->phys_state = 0;
>  	props->port_cap_flags =
>  	    IB_PORT_CM_SUP |
>  	    IB_PORT_SNMP_TUNNEL_SUP |
> @@ -1170,7 +1168,6 @@ static int iwch_query_port(struct ib_device *ibdev,
>  	    IB_PORT_VENDOR_CLASS_SUP | IB_PORT_BOOT_MGMT_SUP;
>  	props->gid_tbl_len = 1;
>  	props->pkey_tbl_len = 1;
> -	props->qkey_viol_cntr = 0;
>  	props->active_width = 2;
>  	props->active_speed = 2;
>  	props->max_msg_sz = -1;
>