[ofa-general] Re: [PATCH] RDMA/nes: nes_cm.c cleanup

Roland Dreier rdreier at cisco.com
Tue Sep 30 14:48:44 PDT 2008


I applied this part:

 > -struct nes_cm_node *mini_cm_connect(struct nes_cm_core *cm_core,
 > +static struct nes_cm_node *mini_cm_connect(struct nes_cm_core *cm_core,

since that clearly makes sense, but I dropped:

 > -	struct nes_qp *nesqp;
 > +	struct nes_qp *nesqp = NULL;

and

 > -	u16 mpa_frame_size = sizeof(struct ietf_mpa_frame) + private_data_len;
 > +	u16 mpa_frame_size = 0;

 > +	mpa_frame_size = sizeof(struct ietf_mpa_frame) +
 > +					private_data_len;

since I don't see any point to those transformations.



More information about the general mailing list