[ofa-general] [PATCH] ibutils: git-log calls have been changed to git log as git-xxx syntax is not working with latest git releases

Jason Gunthorpe jgunthorpe at obsidianresearch.com
Tue Apr 21 22:28:45 PDT 2009


On Tue, Apr 21, 2009 at 09:50:06AM +0200, Nicolas Morey-Chaisemartin wrote:
 
> Signed-off-by: Nicolas Morey-Chaisemartin 
> <nicolas.morey-chaisemartin at ext.bull.net>
>  ibdiag/src/Makefile.am   |    2 +-
>  ibdm/ibdm/Makefile.am    |    2 +-
>  ibis/src/Makefile.am     |    2 +-
>  ibmgtsim/src/Makefile.am |    2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/ibdiag/src/Makefile.am b/ibdiag/src/Makefile.am
> index def8b0a..7158bbd 100644
> +++ b/ibdiag/src/Makefile.am
> @@ -42,7 +42,7 @@ GIT=$(shell which git)
>  
>  git_version.tcl : @MAINTAINER_MODE_TRUE@ FORCE
>  	if test x$(GIT) != x ; then \
> -	   gitver=`cd $(srcdir) ; git-log | head -1 | cut -f2 -d\  `; \
> +	   gitver=`cd $(srcdir) ; git log | head -1 | cut -f2 -d\  `; \
>  	   changes=`cd $(srcdir) ; git diff . | grep ^diff | wc -l`; \

Gah, that is an awful choice of command for this purpose anyhow. All
of those should just be:

git rev-parse --verify HEAD

Which gives the same output, dramatically faster.

Jason



More information about the general mailing list