[ofa-general] [PATCH/Resend] Fixed capability mask problem in ibstat introduec by commit 722b6c6428c9e4921a81f4a6db2838bcee660bb7

Sasha Khapyorsky sashak at voltaire.com
Sat Apr 25 14:02:55 PDT 2009


On 10:27 Fri 24 Apr     , Sean Hefty wrote:
> 
> I think the problem may be in libibumad, umad.c, line 166:
> 
>         if (sys_read_uint64(port_dir, SYS_PORT_CAPMASK, &port->capmask) < 0)
>                 goto clean;
> 
>         port->capmask = htonl(port->capmask);

Yes, the problem is likely here.

OTOH I cannot understand why port->capmask is defined as uint64_t and
not as 32-bit. Kernel uses 32-bit value and it is shown in this file as
0x%0x.

What about to convert type of port->capmask to uint32_t?

Sasha



More information about the general mailing list