[ofa-general] Re: [PATCH] opensm/osm_perfmgr.c: Add assert in sweep_hop_1

Sasha Khapyorsky sashak at voltaire.com
Sat Apr 25 14:10:01 PDT 2009


On 07:03 Tue 21 Apr     , Hal Rosenstock wrote:
> 
> as found in osm_state_mgr.c:state_mgr_sweep_hop_1
> 
> Signed-off-by: Hal Rosenstock <hal.rosenstock at gmail.com>
> ---
> diff --git a/opensm/opensm/osm_perfmgr.c b/opensm/opensm/osm_perfmgr.c
> index 8d5ed97..20ee57d 100644
> --- a/opensm/opensm/osm_perfmgr.c
> +++ b/opensm/opensm/osm_perfmgr.c
> @@ -568,6 +568,8 @@ static int sweep_hop_1(osm_sm_t * sm)
>  	}
>  
>  	p_node = p_port->p_node;
> +	CL_ASSERT(p_node);
> +

port is created using node reference at first - this check is not needed.
Actually instead of copying discovery related code from osm_state_mgr we
need to share it (once it was impossible due to crazy state machine
there, now, then it is reworked already I believe we can reuse most of
the code).

Sasha



More information about the general mailing list