[ofa-general] Re: [PATCH] opensm/osm_ucast_file.c: Fix return status from do_ucast_file_load when file name is not provided

[Sasha Khapyorsky]

Hi Hal,

On 14:19 Thu 06 Aug     , Hal Rosenstock wrote:
> @@ -136,7 +137,7 @@ static int do_ucast_file_load(void *context)
>  		OSM_LOG(&p_osm->log, OSM_LOG_VERBOSE,
>  			"LFTs file name is not given; "
>  			"using default routing algorithm\n");
> -		return 1;
> +		return -1;

This "fix" is not correct. Routing engine method returns "> 0" value
when fallback to default is requested. In particular in case of 'file'
engine it is legal to provide only LFTs file and not provide LID matrix
file.

Sasha