[ofa-general] Re: [PATCH] opensm/osm_ucast_file.c: Fix return status from do_ucast_file_load when file name is not provided

[Hal Rosenstock]

On Wed, Aug 12, 2009 at 6:25 AM, Sasha Khapyorsky <sashak at voltaire.com>wrote:

> On 06:06 Wed 12 Aug     , Hal Rosenstock wrote:
> >
> > What I see is the following when no files are specified:
> > osm_ucast_mgr_process: file tables configured on all switches
> >
> > so file doesn't appear to be falling back in this case.
>
>        if (!r->build_lid_matrices ||
>            (ret = r->build_lid_matrices(r->context)) > 0)
>                ret = osm_ucast_mgr_build_lid_matrices(&osm->sm.ucast_mgr);
>
> So when method is defined and it returns a positive value (file name is
> not specified) OpenSM will build lid matrices using default algorithm
> and will continue with LFT file. This is how things were supposed to
> work.


Does that really make sense for this case when there no files supplied and
file is specified ?

-- Hal


>
>
> Sasha
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20090812/55ffcfd7/attachment.html>