[ofa-general] Re: [PATCH] infiniband-diags/saquery.c: Fix CHECK_AND_SET_VAL macro

[Sasha Khapyorsky]

On 06:56 Sun 16 Aug     , Hal Rosenstock wrote:
> On Sun, Aug 16, 2009 at 6:41 AM, Sasha Khapyorsky <sashak at voltaire.com>wrote:
> 
> > On 06:20 Sun 16 Aug     , Hal Rosenstock wrote:
> > > On Sun, Aug 16, 2009 at 6:02 AM, Sasha Khapyorsky <sashak at voltaire.com
> > >wrote:
> > >
> > > > On 09:46 Sat 15 Aug     , Hal Rosenstock wrote:
> > > > >
> > > > > Changed check from > to != since using integer comparison
> > > > > and some masks can use full range and hence be negative
> > > >
> > > > Any example?
> > >
> > >
> > > Pkey for one.
> >
> > Will you pass negative value of PKey?
> 
> 
> Aren't Pkeys 0x8001 - 0xffff valid ?

Yes, it is valid. And now I'm starting to understand what are you was
about - during the check it will be converted to int16_t and then
negative generated. More detailed patch description would be helpful.

Sasha