[ofa-general] Re: [PATCHv2 RESEND] IB/IPoIB: Don't let a bad muticast address in the join list stop subsequent joins

[Yossi Etigin]

On 24/08/09 20:18, Jason Gunthorpe wrote:
> 1) This is an unlikely failure path 2) It is only O(n) to insert a
> entry into the proper place in an already sorted linked list. 3) I
> think you can do it about four lines of code.
> 
> list_for_each_entry_reverse(i,priv->multicast_list,list) {
>    if (i->xx < mcast->xx || priv->multicast_list == i) {
>        list_move(mcast->list,i->list);
>        break;
>    }
> }
> 


So you suggest putting these 4 lines instead of list_move_tail() ?