[ofa-general] [PATCH] IPoIB: check multicast address format

[Or Gerlitz]

Jason Gunthorpe wrote:
> Check that the format of the multicast link address is correct before taking it from dev->mc_list to priv->multicast_list. This way we never try to send a bogus address to the SA, and prevents badness from erronous 'ip maddr addr add', broken bonding drivers, or whatever.

Jason,

This is great (and simple!) idea, lets go for it.

> Same problem Moni was working on, but lets just address it directly. There is work to try and fix the bonding driver but no fixed version is in mainline yet. This is a cheap and simple work around that is worth having even once the driver is fixed.
Moni,

isn't Jason's approach enough for the bonding case?! I saw that your 
patch ("bonding: clean muticast addresses when device changes type" 
commit e36b9d16c6a6d0f59803b3ef04ff3c22c3844c10) is present in net-next 
and maybe also in mainline .31-rcX . However, it has the 
down-side-effect of e.g loosing routes already set for the the bond 
while adding the underline IPoIB devices, so if Jason's patch is enough 
we can just ask to revert the bonding fix saying we have something better.

Or.