[ofa-general] Re: [PATCH V2] mlx4: Do not allow ib userspace open while device is being removed

Roland Dreier rdreier at cisco.com
Fri Aug 28 10:55:16 PDT 2009


checkpatch output:

WARNING: suspect code indent for conditional statements (8, 12)
#88: FILE: drivers/infiniband/hw/mlx4/main.c:345:
+	if (!dev->ib_active)
+	    return ERR_PTR(-EAGAIN);

ERROR: code indent should use tabs where possible
#107: FILE: drivers/infiniband/hw/mlx4/main.c:737:
+    ^I^Iibdev->ib_active = 0;$

total: 1 errors, 1 warnings, 31 lines checked

not great for a patch this small.  Please clean up.



More information about the general mailing list