[ofa-general] Re: [PATCH] opensm: Add infrastructure support for MulticastFDBTop

[Hal Rosenstock]

On 8/30/09, Sasha Khapyorsky <sashak at voltaire.com> wrote:
>
> On 10:04 Wed 26 Aug     , Hal Rosenstock wrote:
> > @@ -5899,6 +5899,8 @@ typedef struct _ib_switch_info {
> >       ib_net16_t lids_per_port;
> >       ib_net16_t enforce_cap;
> >       uint8_t flags;
> > +     uint8_t resvd;
> > +     ib_net16_t mcast_top;
> >  } PACK_SUFFIX ib_switch_info_t;
> >  #include <complib/cl_packoff.h>
> >  /************/
> > @@ -5908,7 +5910,7 @@ typedef struct _ib_switch_info_record {
> >       ib_net16_t lid;
> >       uint16_t resv0;
> >       ib_switch_info_t switch_info;
> > -     uint8_t pad[3];
> > +     uint8_t pad[1];
>
> Why should be pad[1] here? In struct switch_info you are adding three
> bytes (resvd - 1 and mcast_top - 2), no?


Good catch. It was due to an initial version which didn't have the 16 bit
MFTTop alignment. Do you want a v2 patch for this ?

-- Hal

Sasha
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit
> http://openib.org/mailman/listinfo/openib-general
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20090830/84e8a85a/attachment.html>