[ofa-general] [PATCH 4/4] opensm/osm_subnet.c support subnet configuration rescan and update

Eli Dorfman (Voltaire) dorfman.eli at gmail.com
Tue Feb 3 05:43:21 PST 2009


Sasha Khapyorsky wrote:
> On 16:34 Mon 26 Jan     , Eli Dorfman (Voltaire) wrote:
> 
> [snip...]
>> +
>> +static void opts_setup_routing_engine(osm_subn_t *p_subn, void *p_val)
>> +{
>> +	char *routing_engine_names = (char *) p_val;
>> +
>> +	destroy_routing_engines(p_subn->p_osm);
>> +	setup_routing_engines(p_subn->p_osm, routing_engine_names);
>> +}
> 
> This probably can work with updn and minhops, but it certainly will be
> destructive when LASH routing engine is used. LASH stores internal data
> between sweep cycles, it is used to answer correct SL value in SA
> PathRecord queries. So I think routing engine "switch" should  be a bit
> smarter.
> 

that means that destroy and setup routing engine functions should be improved.
what do you suggest in the meantime? limit this to minhop/updn?

Eli



More information about the general mailing list